forward revert message from low level solidity call












1















I'm working on a proxy contract that will perform calls as follows:



bool success;

bytes memory returndata;

(success, returndata) = _to.call.value(_value)(_data);

require(success);


this works great, except that, if the call reverts with an error message, this function will simply reverts, hiding the reason string.



How can I retrieve the reason string (I assume in the returndata) and use if to revert properly






solidity revert-opcode proxy-contracts







share|improve this question



























    1















    I'm working on a proxy contract that will perform calls as follows:



    bool success;
    
bytes memory returndata;
    
(success, returndata) = _to.call.value(_value)(_data);
    
require(success);


    this works great, except that, if the call reverts with an error message, this function will simply reverts, hiding the reason string.



    How can I retrieve the reason string (I assume in the returndata) and use if to revert properly






    solidity revert-opcode proxy-contracts







    share|improve this question

























      1












      1








      1


      2






      I'm working on a proxy contract that will perform calls as follows:



      bool success;
      
bytes memory returndata;
      
(success, returndata) = _to.call.value(_value)(_data);
      
require(success);


      this works great, except that, if the call reverts with an error message, this function will simply reverts, hiding the reason string.



      How can I retrieve the reason string (I assume in the returndata) and use if to revert properly






      solidity revert-opcode proxy-contracts







      share|improve this question














      I'm working on a proxy contract that will perform calls as follows:



      bool success;
      
bytes memory returndata;
      
(success, returndata) = _to.call.value(_value)(_data);
      
require(success);


      this works great, except that, if the call reverts with an error message, this function will simply reverts, hiding the reason string.



      How can I retrieve the reason string (I assume in the returndata) and use if to revert properly






      solidity revert-opcode proxy-contracts




      solidity revert-opcode proxy-contracts






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Apr 1 at 14:02









      AmxxAmxx

      1185




      1185






















          1 Answer
          1






          active

          oldest

          votes


















          3














          It is simpler than you think:



          require(success, string (returndata));


          See documentation for details. You may also forward raw bytes, but you will need to use assembly.






          share|improve this answer
























          • I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

            – Amxx
            Apr 1 at 14:52












          Your Answer








          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "642"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f69133%2fforward-revert-message-from-low-level-solidity-call%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          3














          It is simpler than you think:



          require(success, string (returndata));


          See documentation for details. You may also forward raw bytes, but you will need to use assembly.






          share|improve this answer
























          • I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

            – Amxx
            Apr 1 at 14:52
















          3














          It is simpler than you think:



          require(success, string (returndata));


          See documentation for details. You may also forward raw bytes, but you will need to use assembly.






          share|improve this answer
























          • I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

            – Amxx
            Apr 1 at 14:52














          3












          3








          3







          It is simpler than you think:



          require(success, string (returndata));


          See documentation for details. You may also forward raw bytes, but you will need to use assembly.






          share|improve this answer













          It is simpler than you think:



          require(success, string (returndata));


          See documentation for details. You may also forward raw bytes, but you will need to use assembly.







          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Apr 1 at 14:31









          Mikhail VladimirovMikhail Vladimirov

          1,351316




          1,351316













          • I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

            – Amxx
            Apr 1 at 14:52



















          • I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

            – Amxx
            Apr 1 at 14:52

















          I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

          – Amxx
          Apr 1 at 14:52





          I tryed require(success, returndata); and started looking into assembly when it failled to compile ... thanks for proving how stupid I am :P

          – Amxx
          Apr 1 at 14:52


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Ethereum Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f69133%2fforward-revert-message-from-low-level-solidity-call%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          -

          Popular posts from this blog

          Færeyskur hestur Heimild | Tengill | Tilvísanir | LeiðsagnarvalRossið - síða um færeyska hrossið á færeyskuGott ár hjá færeyska hestinum

          Image
          FæreyjarHestar færeyskahjaltlandshestinumíslenski hesturinnBretlandskolanámumenskuWikipediafæreyskuWikipediaRossið - síða um færeyska hrossið á færeysku Færeyskur hestur Úr Wikipediu, frjálsa alfræðiritinu Jump to navigation Jump to search Rani og Grani. Grani í vetrarfeldi. Færeyski hesturinn (færeyska: Føroyska rossið ) er hestur sem hefur lifað í Færeyjum í hundruði ára. Hann er smágerður, 120-132 cm á hæð, og helst skyldur hjaltlandshestinum. Hlutverk hans var að draga vagna og plóg og bera klyfjar. Hann hefur fjórar gangtegundir eins og íslenski hesturinn (þar með talið tölt) og er með fjölda litaafbrigði. Nú til dags er hann notaður til frístunda. Í lok 19. aldar voru til um 800 hross. Mörg þeirra voru seld til Bretlands til að vinna í kolanámum og um 1960 voru aðeins nokkrir hestar eftir. Átak var gert í að varðveita hestinn og eru nú til 70-80 hross í Færeyjum. [1] Heimild |   Wikimedia Commons er með margmiðlunarefni sem te
          Read more

          He _____ here since 1970 . Answer needed [closed]What does “since he was so high” mean?Meaning of “catch birds for”?How do I ensure “since” takes the meaning I want?“Who cares here” meaningWhat does “right round toward” mean?the time tense (had now been detected)What does the phrase “ring around the roses” mean here?Correct usage of “visited upon”Meaning of “foiled rail sabotage bid”It was the third time I had gone to Rome or It is the third time I had been to Rome

          Image
          Engineer refusing to file/disclose patents Extending the spectral theorem for bounded self adjoint operators to bounded normal operators Do varchar(max), nvarchar(max) and varbinary(max) columns affect select queries? Why is it that I can sometimes guess the next note? What linear sensor for a keyboard? Why don’t women say שלא עשני גויה and שפחה, according to Ashkenazim? Did arcade monitors have same pixel aspect ratio as TV sets? anything or something to eat Query about absorption line spectra Can I use my Chinese passport to enter China after I acquired another citizenship? Fuse symbol on toroidal transformer Create all possible words using a set or letters Does the Mind Blank spell prevent the target from being frightened? Can I sign legal documents with a smiley face? When quoting, must I also copy hyphens used to divide words that continue on the next line? Hot bath for aluminium engine block and heads Journal losing indexing services Is it possib
          Read more

          Bunad

          Image
          Tradisjonelle folkedrakter frå Aust-Telemark, truleg frå 1880-åra. Drakter som dette er grunnlaget for moderne bunadar. Foto: Axel Lindahl Bunad frå Eggedal i Buskerud fotografert i 1906. Bunad (frå kledebunad , der norrønt «búnaðr» har same rot som (føre)bu) er ei samnemning brukt om klesdrakter i tradisjonell nordisk stil — ofte utvikla frå folkedrakter, men likevel i ein eigen tradisjon. Ein bunad er typisk ei forseggjort og kostbar drakt, med mykje broderi, og med handsmidde smykke i gull eller sølv, særleg dei særeigne søljene, som obligatorisk prynad i tillegg. Bunad og bunadbruk er eit debattemne med mange ulike oppfatningar, til dømes om kva som er ein bunad, og om ein kan endra på utforminga av draktene eller ikkje. Den norske bunadrørsla går tilbake til folkedansrørsla og føregangsfolk som Hulda Garborg og Klara Semb. I dag blir bunad brukt som nasjonaldrakt. Festbunad er likestilt med galla-antrekk, og ofte nytta ved særskilde høve, som konfirmasjonar eller d
          Read more