Determine whether an integer is a palindrome





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







4












$begingroup$


The task




Determine whether an integer is a palindrome. An integer is a
palindrome when it reads the same backward as forward.



Example 1:



Input: 121 Output: true



Example 2:



Input: -121 Output: false Explanation: From left to right, it reads
-121. From right to left, it becomes 121-. Therefore it is not a palindrome.



Example 3:



Input: 10 Output: false Explanation: Reads 01 from right to left.
Therefore it is not a palindrome. Follow up:



Could you solve it without converting the integer to a string?




My solution
with converting number to string



const isPalindrome = n => n >= 0 && Number([...`${n}`].reverse().join("")) === n;

console.log(isPalindrome(121));


My solution
without converting number to string



const isPalindrome2 = n => {
if (n < 0) { return false; }
let num = Math.abs(n);
const arr = ;
let i = 1;
while (num > 0) {
const min = num % (10 ** i);
num = num - min;
i++;
arr.push(min);
}
i = i - 2;
let j = 0;
return n === arr.reduce((res, x) => {
const add = (x/ (10 ** j)) * (10 ** i);
res += add;
i--;
j++;
return res;
}, 0);
};

console.log(isPalindrome2(121));









share|improve this question











$endgroup$








  • 1




    $begingroup$
    That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
    $endgroup$
    – Mast
    Apr 21 at 11:44










  • $begingroup$
    I wanted to solve it without converting the number to a string. @Mast
    $endgroup$
    – thadeuszlay
    Apr 21 at 11:56










  • $begingroup$
    That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
    $endgroup$
    – Mast
    Apr 21 at 13:01










  • $begingroup$
    @thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
    $endgroup$
    – Sulthan
    Apr 21 at 18:57






  • 2




    $begingroup$
    @Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
    $endgroup$
    – David Z
    Apr 21 at 22:00




















4












$begingroup$


The task




Determine whether an integer is a palindrome. An integer is a
palindrome when it reads the same backward as forward.



Example 1:



Input: 121 Output: true



Example 2:



Input: -121 Output: false Explanation: From left to right, it reads
-121. From right to left, it becomes 121-. Therefore it is not a palindrome.



Example 3:



Input: 10 Output: false Explanation: Reads 01 from right to left.
Therefore it is not a palindrome. Follow up:



Could you solve it without converting the integer to a string?




My solution
with converting number to string



const isPalindrome = n => n >= 0 && Number([...`${n}`].reverse().join("")) === n;

console.log(isPalindrome(121));


My solution
without converting number to string



const isPalindrome2 = n => {
if (n < 0) { return false; }
let num = Math.abs(n);
const arr = ;
let i = 1;
while (num > 0) {
const min = num % (10 ** i);
num = num - min;
i++;
arr.push(min);
}
i = i - 2;
let j = 0;
return n === arr.reduce((res, x) => {
const add = (x/ (10 ** j)) * (10 ** i);
res += add;
i--;
j++;
return res;
}, 0);
};

console.log(isPalindrome2(121));









share|improve this question











$endgroup$








  • 1




    $begingroup$
    That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
    $endgroup$
    – Mast
    Apr 21 at 11:44










  • $begingroup$
    I wanted to solve it without converting the number to a string. @Mast
    $endgroup$
    – thadeuszlay
    Apr 21 at 11:56










  • $begingroup$
    That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
    $endgroup$
    – Mast
    Apr 21 at 13:01










  • $begingroup$
    @thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
    $endgroup$
    – Sulthan
    Apr 21 at 18:57






  • 2




    $begingroup$
    @Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
    $endgroup$
    – David Z
    Apr 21 at 22:00
















4












4








4





$begingroup$


The task




Determine whether an integer is a palindrome. An integer is a
palindrome when it reads the same backward as forward.



Example 1:



Input: 121 Output: true



Example 2:



Input: -121 Output: false Explanation: From left to right, it reads
-121. From right to left, it becomes 121-. Therefore it is not a palindrome.



Example 3:



Input: 10 Output: false Explanation: Reads 01 from right to left.
Therefore it is not a palindrome. Follow up:



Could you solve it without converting the integer to a string?




My solution
with converting number to string



const isPalindrome = n => n >= 0 && Number([...`${n}`].reverse().join("")) === n;

console.log(isPalindrome(121));


My solution
without converting number to string



const isPalindrome2 = n => {
if (n < 0) { return false; }
let num = Math.abs(n);
const arr = ;
let i = 1;
while (num > 0) {
const min = num % (10 ** i);
num = num - min;
i++;
arr.push(min);
}
i = i - 2;
let j = 0;
return n === arr.reduce((res, x) => {
const add = (x/ (10 ** j)) * (10 ** i);
res += add;
i--;
j++;
return res;
}, 0);
};

console.log(isPalindrome2(121));









share|improve this question











$endgroup$




The task




Determine whether an integer is a palindrome. An integer is a
palindrome when it reads the same backward as forward.



Example 1:



Input: 121 Output: true



Example 2:



Input: -121 Output: false Explanation: From left to right, it reads
-121. From right to left, it becomes 121-. Therefore it is not a palindrome.



Example 3:



Input: 10 Output: false Explanation: Reads 01 from right to left.
Therefore it is not a palindrome. Follow up:



Could you solve it without converting the integer to a string?




My solution
with converting number to string



const isPalindrome = n => n >= 0 && Number([...`${n}`].reverse().join("")) === n;

console.log(isPalindrome(121));


My solution
without converting number to string



const isPalindrome2 = n => {
if (n < 0) { return false; }
let num = Math.abs(n);
const arr = ;
let i = 1;
while (num > 0) {
const min = num % (10 ** i);
num = num - min;
i++;
arr.push(min);
}
i = i - 2;
let j = 0;
return n === arr.reduce((res, x) => {
const add = (x/ (10 ** j)) * (10 ** i);
res += add;
i--;
j++;
return res;
}, 0);
};

console.log(isPalindrome2(121));






javascript algorithm programming-challenge ecmascript-6 palindrome






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Apr 21 at 12:00







thadeuszlay

















asked Apr 21 at 11:23









thadeuszlaythadeuszlay

1,345616




1,345616








  • 1




    $begingroup$
    That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
    $endgroup$
    – Mast
    Apr 21 at 11:44










  • $begingroup$
    I wanted to solve it without converting the number to a string. @Mast
    $endgroup$
    – thadeuszlay
    Apr 21 at 11:56










  • $begingroup$
    That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
    $endgroup$
    – Mast
    Apr 21 at 13:01










  • $begingroup$
    @thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
    $endgroup$
    – Sulthan
    Apr 21 at 18:57






  • 2




    $begingroup$
    @Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
    $endgroup$
    – David Z
    Apr 21 at 22:00
















  • 1




    $begingroup$
    That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
    $endgroup$
    – Mast
    Apr 21 at 11:44










  • $begingroup$
    I wanted to solve it without converting the number to a string. @Mast
    $endgroup$
    – thadeuszlay
    Apr 21 at 11:56










  • $begingroup$
    That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
    $endgroup$
    – Mast
    Apr 21 at 13:01










  • $begingroup$
    @thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
    $endgroup$
    – Sulthan
    Apr 21 at 18:57






  • 2




    $begingroup$
    @Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
    $endgroup$
    – David Z
    Apr 21 at 22:00










1




1




$begingroup$
That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
$endgroup$
– Mast
Apr 21 at 11:44




$begingroup$
That's an awfully convoluted way to check for your objective. Can you tell us more about why you did it this way?
$endgroup$
– Mast
Apr 21 at 11:44












$begingroup$
I wanted to solve it without converting the number to a string. @Mast
$endgroup$
– thadeuszlay
Apr 21 at 11:56




$begingroup$
I wanted to solve it without converting the number to a string. @Mast
$endgroup$
– thadeuszlay
Apr 21 at 11:56












$begingroup$
That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
$endgroup$
– Mast
Apr 21 at 13:01




$begingroup$
That explains it in part, but it's still an odd way to do it. I hope my answer points out why I was so surprised.
$endgroup$
– Mast
Apr 21 at 13:01












$begingroup$
@thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
$endgroup$
– Sulthan
Apr 21 at 18:57




$begingroup$
@thadeuszlay Palindrome is not defined on numbers, it's defined on strings. In this case you want decadic string representing the given number. You have to convert it to a string or a similar representation (e.g. array of decadic digits).
$endgroup$
– Sulthan
Apr 21 at 18:57




2




2




$begingroup$
@Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
$endgroup$
– David Z
Apr 21 at 22:00






$begingroup$
@Sulthan well, you don't necessarily need an array or string. The answers show how you can do this without splitting up the digits. But it is true that you need to know the base, and that a fully explicit version of the question should ask whether the base-10 (or whatever) representation of the integer is a palindrome, since that's a property of the representation but not of the integer itself.
$endgroup$
– David Z
Apr 21 at 22:00












3 Answers
3






active

oldest

votes


















1












$begingroup$

Count digits in positive integer



You can get the number of digits using log10



eg



Math.log10(13526); // is 4.131169383089324
const digits = Math.ceil(Math.log10(13526)); // 5


You can get the unit value eg 423 is 100 or 256378 is 100000 by raising 10 to the power of the number of digits minus one. Well not for powers of 10



eg



unit = 10 ** (Math.ceil(Math.log10(13526)) -1); // 10000
unit = 10 ** (Math.ceil(Math.log10(10000)) -1); // 1000 wrong for power of 10 number


To get the value we want we need to floor the log first



unit = 10 ** Math.floor(Math.log10(10000)); // 10000
unit = 10 ** Math.floor(Math.log10(13526)); // 10000 correct


or



unit = 10 ** (Math.log10(10000) | 0); // 10000
unit = 10 ** (Math.log10(13526) | 0); // 10000


Get digit at position of positive integer



To get the digit at any position in a number divide it by 10 raised to the power of the digit position get the remainder of that divided by 10 and floor it.



const digitAt = (val, digit) => Math.floor(val / 10 ** digit % 10);


or



const digitAt = (val, digit) => val / 10 ** digit % 10 | 0;

// Note brackets added only to clarify order and are not needed
// ((val / (10 ** digit)) % 10) | 0;

digitAt(567, 0); // 7
digitAt(567, 1); // 6
digitAt(567, 2); // 5


Positive integer a palindrome in $O(1)$ space



With that info you can then build a function that does test in $O(1)$ space, as you do not need to store the digits in an array for later comparison.



To keep performance up we can avoid the slower versions of some operation. For floor we can | 0 (note that for large numbers > 2**31-1 you must use floor) and for ** use Math.pow



Rather than do the full calculation to get the digit we can store the unit value of the digit we want for the top and bottom and multiply by 10 to move up and divide by 10 to move down.



function isPalindrome(num) {
var top = Math.pow(10, Math.log10(num) | 0), bot = 1;
while (top >= bot) {
if ((num / top % 10 | 0) !== (num / bot % 10 | 0)) { return false }
top /= 10;
bot *= 10;
}
return true;
}



  • The function will returns false for negative numbers but is not optimized for them

  • The function only works on integer values less than Number.MAX_SAFE_INTEGER which is 9007199254740991


In terms of performance the above function is 5 times faster for a 16 digit palindrome 2192123993212912 and 10-11 times faster for a non palindrome of 16 digits






share|improve this answer









$endgroup$









  • 2




    $begingroup$
    Don't suggest floating-point arithmetic when solving integer problems.
    $endgroup$
    – Roland Illig
    Apr 21 at 22:39












  • $begingroup$
    @RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
    $endgroup$
    – Blindman67
    Apr 22 at 5:52










  • $begingroup$
    The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
    $endgroup$
    – Roland Illig
    Apr 22 at 6:23






  • 1




    $begingroup$
    @RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
    $endgroup$
    – Blindman67
    Apr 22 at 6:42






  • 1




    $begingroup$
    @RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
    $endgroup$
    – Blindman67
    Apr 22 at 6:46



















5












$begingroup$

Your second solution is awfully complicated for something simple.



You start out alright. No negative number can be a palindrome, so we can discount those. However, 0 is always a palindrome, so you're discounting that while you shouldn't.



You do a lot of complicated math and use an array. You could use either, but shouldn't use both. There are a couple of mathematical approaches to solve this, but you should be able to use those without iterating over the individual numbers or splitting it up at all. The most obvious solution however, is using an array and direct comparisons, without any math.



Say we got 1221. Split it up. [1, 2, 2, 1]. Iterate over the array, comparing every nth character to the last-nth character. 0th to 3rd. 1st to 2nd.



Say we got 92429. Split it up. [9, 2, 4, 2, 9]. Ignore the middle character. Handle the rest like it's an even-length number.



Based on those 2 cases, you should be able to figure out a much simpler algorithm.



Note: This answers the explicit question. Implicitly, you should wonder whether arrays should be allowed for this challenge. After all, iterating over a string or an array, it's not that different. I strongly suspect they want you to use the math-only approach.



Another approach, which is somewhat math-based and you should beware of overflows, is simply reversing the number.
In pseudo-code, that would look something like this:



reverse = 0
while (number != 0) {
reverse = reverse * 10 + number % 10;
number /= 10;
}


Check the input versus its reversed number. If they are the same, it's a palindrome.



But this still uses extra memory to hold the additional integer we just created.



Can it be done without? Absolutely. But I'll leave that as an exercise for you.






share|improve this answer











$endgroup$













  • $begingroup$
    How would you split it up?
    $endgroup$
    – thadeuszlay
    Apr 21 at 16:23










  • $begingroup$
    You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
    $endgroup$
    – Sulthan
    Apr 21 at 19:01










  • $begingroup$
    @Sulthan Yes, but that's a philosophical discussion, not a review.
    $endgroup$
    – Mast
    Apr 21 at 20:26






  • 1




    $begingroup$
    You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
    $endgroup$
    – Deduplicator
    Apr 21 at 22:13










  • $begingroup$
    @Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
    $endgroup$
    – Roland Illig
    Apr 22 at 6:36



















2












$begingroup$

Are you sure you should generate all those objects and arrays?

And the second code additionally looks quite complex.



Testing whether a number is palindromic is actually quite simple:



function isPalindrome(num) {
var rev = 0
while (rev < num) {
rev = rev * 10 + num % 10
num /= 10
}
return rev == num || rev / 10 == num
}





share|improve this answer









$endgroup$













  • $begingroup$
    This is JavaScript, therefore it's better to compare using === instead of ==.
    $endgroup$
    – Roland Illig
    Apr 22 at 16:36












Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217827%2fdetermine-whether-an-integer-is-a-palindrome%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























3 Answers
3






active

oldest

votes








3 Answers
3






active

oldest

votes









active

oldest

votes






active

oldest

votes









1












$begingroup$

Count digits in positive integer



You can get the number of digits using log10



eg



Math.log10(13526); // is 4.131169383089324
const digits = Math.ceil(Math.log10(13526)); // 5


You can get the unit value eg 423 is 100 or 256378 is 100000 by raising 10 to the power of the number of digits minus one. Well not for powers of 10



eg



unit = 10 ** (Math.ceil(Math.log10(13526)) -1); // 10000
unit = 10 ** (Math.ceil(Math.log10(10000)) -1); // 1000 wrong for power of 10 number


To get the value we want we need to floor the log first



unit = 10 ** Math.floor(Math.log10(10000)); // 10000
unit = 10 ** Math.floor(Math.log10(13526)); // 10000 correct


or



unit = 10 ** (Math.log10(10000) | 0); // 10000
unit = 10 ** (Math.log10(13526) | 0); // 10000


Get digit at position of positive integer



To get the digit at any position in a number divide it by 10 raised to the power of the digit position get the remainder of that divided by 10 and floor it.



const digitAt = (val, digit) => Math.floor(val / 10 ** digit % 10);


or



const digitAt = (val, digit) => val / 10 ** digit % 10 | 0;

// Note brackets added only to clarify order and are not needed
// ((val / (10 ** digit)) % 10) | 0;

digitAt(567, 0); // 7
digitAt(567, 1); // 6
digitAt(567, 2); // 5


Positive integer a palindrome in $O(1)$ space



With that info you can then build a function that does test in $O(1)$ space, as you do not need to store the digits in an array for later comparison.



To keep performance up we can avoid the slower versions of some operation. For floor we can | 0 (note that for large numbers > 2**31-1 you must use floor) and for ** use Math.pow



Rather than do the full calculation to get the digit we can store the unit value of the digit we want for the top and bottom and multiply by 10 to move up and divide by 10 to move down.



function isPalindrome(num) {
var top = Math.pow(10, Math.log10(num) | 0), bot = 1;
while (top >= bot) {
if ((num / top % 10 | 0) !== (num / bot % 10 | 0)) { return false }
top /= 10;
bot *= 10;
}
return true;
}



  • The function will returns false for negative numbers but is not optimized for them

  • The function only works on integer values less than Number.MAX_SAFE_INTEGER which is 9007199254740991


In terms of performance the above function is 5 times faster for a 16 digit palindrome 2192123993212912 and 10-11 times faster for a non palindrome of 16 digits






share|improve this answer









$endgroup$









  • 2




    $begingroup$
    Don't suggest floating-point arithmetic when solving integer problems.
    $endgroup$
    – Roland Illig
    Apr 21 at 22:39












  • $begingroup$
    @RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
    $endgroup$
    – Blindman67
    Apr 22 at 5:52










  • $begingroup$
    The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
    $endgroup$
    – Roland Illig
    Apr 22 at 6:23






  • 1




    $begingroup$
    @RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
    $endgroup$
    – Blindman67
    Apr 22 at 6:42






  • 1




    $begingroup$
    @RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
    $endgroup$
    – Blindman67
    Apr 22 at 6:46
















1












$begingroup$

Count digits in positive integer



You can get the number of digits using log10



eg



Math.log10(13526); // is 4.131169383089324
const digits = Math.ceil(Math.log10(13526)); // 5


You can get the unit value eg 423 is 100 or 256378 is 100000 by raising 10 to the power of the number of digits minus one. Well not for powers of 10



eg



unit = 10 ** (Math.ceil(Math.log10(13526)) -1); // 10000
unit = 10 ** (Math.ceil(Math.log10(10000)) -1); // 1000 wrong for power of 10 number


To get the value we want we need to floor the log first



unit = 10 ** Math.floor(Math.log10(10000)); // 10000
unit = 10 ** Math.floor(Math.log10(13526)); // 10000 correct


or



unit = 10 ** (Math.log10(10000) | 0); // 10000
unit = 10 ** (Math.log10(13526) | 0); // 10000


Get digit at position of positive integer



To get the digit at any position in a number divide it by 10 raised to the power of the digit position get the remainder of that divided by 10 and floor it.



const digitAt = (val, digit) => Math.floor(val / 10 ** digit % 10);


or



const digitAt = (val, digit) => val / 10 ** digit % 10 | 0;

// Note brackets added only to clarify order and are not needed
// ((val / (10 ** digit)) % 10) | 0;

digitAt(567, 0); // 7
digitAt(567, 1); // 6
digitAt(567, 2); // 5


Positive integer a palindrome in $O(1)$ space



With that info you can then build a function that does test in $O(1)$ space, as you do not need to store the digits in an array for later comparison.



To keep performance up we can avoid the slower versions of some operation. For floor we can | 0 (note that for large numbers > 2**31-1 you must use floor) and for ** use Math.pow



Rather than do the full calculation to get the digit we can store the unit value of the digit we want for the top and bottom and multiply by 10 to move up and divide by 10 to move down.



function isPalindrome(num) {
var top = Math.pow(10, Math.log10(num) | 0), bot = 1;
while (top >= bot) {
if ((num / top % 10 | 0) !== (num / bot % 10 | 0)) { return false }
top /= 10;
bot *= 10;
}
return true;
}



  • The function will returns false for negative numbers but is not optimized for them

  • The function only works on integer values less than Number.MAX_SAFE_INTEGER which is 9007199254740991


In terms of performance the above function is 5 times faster for a 16 digit palindrome 2192123993212912 and 10-11 times faster for a non palindrome of 16 digits






share|improve this answer









$endgroup$









  • 2




    $begingroup$
    Don't suggest floating-point arithmetic when solving integer problems.
    $endgroup$
    – Roland Illig
    Apr 21 at 22:39












  • $begingroup$
    @RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
    $endgroup$
    – Blindman67
    Apr 22 at 5:52










  • $begingroup$
    The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
    $endgroup$
    – Roland Illig
    Apr 22 at 6:23






  • 1




    $begingroup$
    @RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
    $endgroup$
    – Blindman67
    Apr 22 at 6:42






  • 1




    $begingroup$
    @RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
    $endgroup$
    – Blindman67
    Apr 22 at 6:46














1












1








1





$begingroup$

Count digits in positive integer



You can get the number of digits using log10



eg



Math.log10(13526); // is 4.131169383089324
const digits = Math.ceil(Math.log10(13526)); // 5


You can get the unit value eg 423 is 100 or 256378 is 100000 by raising 10 to the power of the number of digits minus one. Well not for powers of 10



eg



unit = 10 ** (Math.ceil(Math.log10(13526)) -1); // 10000
unit = 10 ** (Math.ceil(Math.log10(10000)) -1); // 1000 wrong for power of 10 number


To get the value we want we need to floor the log first



unit = 10 ** Math.floor(Math.log10(10000)); // 10000
unit = 10 ** Math.floor(Math.log10(13526)); // 10000 correct


or



unit = 10 ** (Math.log10(10000) | 0); // 10000
unit = 10 ** (Math.log10(13526) | 0); // 10000


Get digit at position of positive integer



To get the digit at any position in a number divide it by 10 raised to the power of the digit position get the remainder of that divided by 10 and floor it.



const digitAt = (val, digit) => Math.floor(val / 10 ** digit % 10);


or



const digitAt = (val, digit) => val / 10 ** digit % 10 | 0;

// Note brackets added only to clarify order and are not needed
// ((val / (10 ** digit)) % 10) | 0;

digitAt(567, 0); // 7
digitAt(567, 1); // 6
digitAt(567, 2); // 5


Positive integer a palindrome in $O(1)$ space



With that info you can then build a function that does test in $O(1)$ space, as you do not need to store the digits in an array for later comparison.



To keep performance up we can avoid the slower versions of some operation. For floor we can | 0 (note that for large numbers > 2**31-1 you must use floor) and for ** use Math.pow



Rather than do the full calculation to get the digit we can store the unit value of the digit we want for the top and bottom and multiply by 10 to move up and divide by 10 to move down.



function isPalindrome(num) {
var top = Math.pow(10, Math.log10(num) | 0), bot = 1;
while (top >= bot) {
if ((num / top % 10 | 0) !== (num / bot % 10 | 0)) { return false }
top /= 10;
bot *= 10;
}
return true;
}



  • The function will returns false for negative numbers but is not optimized for them

  • The function only works on integer values less than Number.MAX_SAFE_INTEGER which is 9007199254740991


In terms of performance the above function is 5 times faster for a 16 digit palindrome 2192123993212912 and 10-11 times faster for a non palindrome of 16 digits






share|improve this answer









$endgroup$



Count digits in positive integer



You can get the number of digits using log10



eg



Math.log10(13526); // is 4.131169383089324
const digits = Math.ceil(Math.log10(13526)); // 5


You can get the unit value eg 423 is 100 or 256378 is 100000 by raising 10 to the power of the number of digits minus one. Well not for powers of 10



eg



unit = 10 ** (Math.ceil(Math.log10(13526)) -1); // 10000
unit = 10 ** (Math.ceil(Math.log10(10000)) -1); // 1000 wrong for power of 10 number


To get the value we want we need to floor the log first



unit = 10 ** Math.floor(Math.log10(10000)); // 10000
unit = 10 ** Math.floor(Math.log10(13526)); // 10000 correct


or



unit = 10 ** (Math.log10(10000) | 0); // 10000
unit = 10 ** (Math.log10(13526) | 0); // 10000


Get digit at position of positive integer



To get the digit at any position in a number divide it by 10 raised to the power of the digit position get the remainder of that divided by 10 and floor it.



const digitAt = (val, digit) => Math.floor(val / 10 ** digit % 10);


or



const digitAt = (val, digit) => val / 10 ** digit % 10 | 0;

// Note brackets added only to clarify order and are not needed
// ((val / (10 ** digit)) % 10) | 0;

digitAt(567, 0); // 7
digitAt(567, 1); // 6
digitAt(567, 2); // 5


Positive integer a palindrome in $O(1)$ space



With that info you can then build a function that does test in $O(1)$ space, as you do not need to store the digits in an array for later comparison.



To keep performance up we can avoid the slower versions of some operation. For floor we can | 0 (note that for large numbers > 2**31-1 you must use floor) and for ** use Math.pow



Rather than do the full calculation to get the digit we can store the unit value of the digit we want for the top and bottom and multiply by 10 to move up and divide by 10 to move down.



function isPalindrome(num) {
var top = Math.pow(10, Math.log10(num) | 0), bot = 1;
while (top >= bot) {
if ((num / top % 10 | 0) !== (num / bot % 10 | 0)) { return false }
top /= 10;
bot *= 10;
}
return true;
}



  • The function will returns false for negative numbers but is not optimized for them

  • The function only works on integer values less than Number.MAX_SAFE_INTEGER which is 9007199254740991


In terms of performance the above function is 5 times faster for a 16 digit palindrome 2192123993212912 and 10-11 times faster for a non palindrome of 16 digits







share|improve this answer












share|improve this answer



share|improve this answer










answered Apr 21 at 19:53









Blindman67Blindman67

11.3k1623




11.3k1623








  • 2




    $begingroup$
    Don't suggest floating-point arithmetic when solving integer problems.
    $endgroup$
    – Roland Illig
    Apr 21 at 22:39












  • $begingroup$
    @RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
    $endgroup$
    – Blindman67
    Apr 22 at 5:52










  • $begingroup$
    The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
    $endgroup$
    – Roland Illig
    Apr 22 at 6:23






  • 1




    $begingroup$
    @RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
    $endgroup$
    – Blindman67
    Apr 22 at 6:42






  • 1




    $begingroup$
    @RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
    $endgroup$
    – Blindman67
    Apr 22 at 6:46














  • 2




    $begingroup$
    Don't suggest floating-point arithmetic when solving integer problems.
    $endgroup$
    – Roland Illig
    Apr 21 at 22:39












  • $begingroup$
    @RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
    $endgroup$
    – Blindman67
    Apr 22 at 5:52










  • $begingroup$
    The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
    $endgroup$
    – Roland Illig
    Apr 22 at 6:23






  • 1




    $begingroup$
    @RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
    $endgroup$
    – Blindman67
    Apr 22 at 6:42






  • 1




    $begingroup$
    @RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
    $endgroup$
    – Blindman67
    Apr 22 at 6:46








2




2




$begingroup$
Don't suggest floating-point arithmetic when solving integer problems.
$endgroup$
– Roland Illig
Apr 21 at 22:39






$begingroup$
Don't suggest floating-point arithmetic when solving integer problems.
$endgroup$
– Roland Illig
Apr 21 at 22:39














$begingroup$
@RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
$endgroup$
– Blindman67
Apr 22 at 5:52




$begingroup$
@RolandIllig Really??? Are you unfamiliar with Javascript? . Using math operators /, *, % evaluate as doubles, Meaning that what you are saying is dont use math operators to solve integer problems,
$endgroup$
– Blindman67
Apr 22 at 5:52












$begingroup$
The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
$endgroup$
– Roland Illig
Apr 22 at 6:23




$begingroup$
The crucial point is that IEEE 754-2008 guarantees that the +, -, *, / and sqrt operators produce results that are as close to the mathematical truth as possible. There is no such guarantee for log10 or sin, and thus using these functions may introduce rounding errors.
$endgroup$
– Roland Illig
Apr 22 at 6:23




1




1




$begingroup$
@RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
$endgroup$
– Blindman67
Apr 22 at 6:42




$begingroup$
@RolandIllig What??? You are saying, all answers no matter what the tag must be language neutral, I think I will avoid that complication. Anyways the | operator converts to int 32 and Math.log10 in javascript will never let (Math.log10(n)|0) !== (Math.log10(n+1)|0) be true, where n is positive int (excluding 9, 99, 999, 9999, 99999... ). So prove me wrong, all you need is a number for n
$endgroup$
– Blindman67
Apr 22 at 6:42




1




1




$begingroup$
@RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
$endgroup$
– Blindman67
Apr 22 at 6:46




$begingroup$
@RolandIllig By the way did you read my answer "only works on integer values less than Number.MAX_SAFE_INTEGER" a clear warning regarding possible rounding errors
$endgroup$
– Blindman67
Apr 22 at 6:46













5












$begingroup$

Your second solution is awfully complicated for something simple.



You start out alright. No negative number can be a palindrome, so we can discount those. However, 0 is always a palindrome, so you're discounting that while you shouldn't.



You do a lot of complicated math and use an array. You could use either, but shouldn't use both. There are a couple of mathematical approaches to solve this, but you should be able to use those without iterating over the individual numbers or splitting it up at all. The most obvious solution however, is using an array and direct comparisons, without any math.



Say we got 1221. Split it up. [1, 2, 2, 1]. Iterate over the array, comparing every nth character to the last-nth character. 0th to 3rd. 1st to 2nd.



Say we got 92429. Split it up. [9, 2, 4, 2, 9]. Ignore the middle character. Handle the rest like it's an even-length number.



Based on those 2 cases, you should be able to figure out a much simpler algorithm.



Note: This answers the explicit question. Implicitly, you should wonder whether arrays should be allowed for this challenge. After all, iterating over a string or an array, it's not that different. I strongly suspect they want you to use the math-only approach.



Another approach, which is somewhat math-based and you should beware of overflows, is simply reversing the number.
In pseudo-code, that would look something like this:



reverse = 0
while (number != 0) {
reverse = reverse * 10 + number % 10;
number /= 10;
}


Check the input versus its reversed number. If they are the same, it's a palindrome.



But this still uses extra memory to hold the additional integer we just created.



Can it be done without? Absolutely. But I'll leave that as an exercise for you.






share|improve this answer











$endgroup$













  • $begingroup$
    How would you split it up?
    $endgroup$
    – thadeuszlay
    Apr 21 at 16:23










  • $begingroup$
    You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
    $endgroup$
    – Sulthan
    Apr 21 at 19:01










  • $begingroup$
    @Sulthan Yes, but that's a philosophical discussion, not a review.
    $endgroup$
    – Mast
    Apr 21 at 20:26






  • 1




    $begingroup$
    You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
    $endgroup$
    – Deduplicator
    Apr 21 at 22:13










  • $begingroup$
    @Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
    $endgroup$
    – Roland Illig
    Apr 22 at 6:36
















5












$begingroup$

Your second solution is awfully complicated for something simple.



You start out alright. No negative number can be a palindrome, so we can discount those. However, 0 is always a palindrome, so you're discounting that while you shouldn't.



You do a lot of complicated math and use an array. You could use either, but shouldn't use both. There are a couple of mathematical approaches to solve this, but you should be able to use those without iterating over the individual numbers or splitting it up at all. The most obvious solution however, is using an array and direct comparisons, without any math.



Say we got 1221. Split it up. [1, 2, 2, 1]. Iterate over the array, comparing every nth character to the last-nth character. 0th to 3rd. 1st to 2nd.



Say we got 92429. Split it up. [9, 2, 4, 2, 9]. Ignore the middle character. Handle the rest like it's an even-length number.



Based on those 2 cases, you should be able to figure out a much simpler algorithm.



Note: This answers the explicit question. Implicitly, you should wonder whether arrays should be allowed for this challenge. After all, iterating over a string or an array, it's not that different. I strongly suspect they want you to use the math-only approach.



Another approach, which is somewhat math-based and you should beware of overflows, is simply reversing the number.
In pseudo-code, that would look something like this:



reverse = 0
while (number != 0) {
reverse = reverse * 10 + number % 10;
number /= 10;
}


Check the input versus its reversed number. If they are the same, it's a palindrome.



But this still uses extra memory to hold the additional integer we just created.



Can it be done without? Absolutely. But I'll leave that as an exercise for you.






share|improve this answer











$endgroup$













  • $begingroup$
    How would you split it up?
    $endgroup$
    – thadeuszlay
    Apr 21 at 16:23










  • $begingroup$
    You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
    $endgroup$
    – Sulthan
    Apr 21 at 19:01










  • $begingroup$
    @Sulthan Yes, but that's a philosophical discussion, not a review.
    $endgroup$
    – Mast
    Apr 21 at 20:26






  • 1




    $begingroup$
    You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
    $endgroup$
    – Deduplicator
    Apr 21 at 22:13










  • $begingroup$
    @Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
    $endgroup$
    – Roland Illig
    Apr 22 at 6:36














5












5








5





$begingroup$

Your second solution is awfully complicated for something simple.



You start out alright. No negative number can be a palindrome, so we can discount those. However, 0 is always a palindrome, so you're discounting that while you shouldn't.



You do a lot of complicated math and use an array. You could use either, but shouldn't use both. There are a couple of mathematical approaches to solve this, but you should be able to use those without iterating over the individual numbers or splitting it up at all. The most obvious solution however, is using an array and direct comparisons, without any math.



Say we got 1221. Split it up. [1, 2, 2, 1]. Iterate over the array, comparing every nth character to the last-nth character. 0th to 3rd. 1st to 2nd.



Say we got 92429. Split it up. [9, 2, 4, 2, 9]. Ignore the middle character. Handle the rest like it's an even-length number.



Based on those 2 cases, you should be able to figure out a much simpler algorithm.



Note: This answers the explicit question. Implicitly, you should wonder whether arrays should be allowed for this challenge. After all, iterating over a string or an array, it's not that different. I strongly suspect they want you to use the math-only approach.



Another approach, which is somewhat math-based and you should beware of overflows, is simply reversing the number.
In pseudo-code, that would look something like this:



reverse = 0
while (number != 0) {
reverse = reverse * 10 + number % 10;
number /= 10;
}


Check the input versus its reversed number. If they are the same, it's a palindrome.



But this still uses extra memory to hold the additional integer we just created.



Can it be done without? Absolutely. But I'll leave that as an exercise for you.






share|improve this answer











$endgroup$



Your second solution is awfully complicated for something simple.



You start out alright. No negative number can be a palindrome, so we can discount those. However, 0 is always a palindrome, so you're discounting that while you shouldn't.



You do a lot of complicated math and use an array. You could use either, but shouldn't use both. There are a couple of mathematical approaches to solve this, but you should be able to use those without iterating over the individual numbers or splitting it up at all. The most obvious solution however, is using an array and direct comparisons, without any math.



Say we got 1221. Split it up. [1, 2, 2, 1]. Iterate over the array, comparing every nth character to the last-nth character. 0th to 3rd. 1st to 2nd.



Say we got 92429. Split it up. [9, 2, 4, 2, 9]. Ignore the middle character. Handle the rest like it's an even-length number.



Based on those 2 cases, you should be able to figure out a much simpler algorithm.



Note: This answers the explicit question. Implicitly, you should wonder whether arrays should be allowed for this challenge. After all, iterating over a string or an array, it's not that different. I strongly suspect they want you to use the math-only approach.



Another approach, which is somewhat math-based and you should beware of overflows, is simply reversing the number.
In pseudo-code, that would look something like this:



reverse = 0
while (number != 0) {
reverse = reverse * 10 + number % 10;
number /= 10;
}


Check the input versus its reversed number. If they are the same, it's a palindrome.



But this still uses extra memory to hold the additional integer we just created.



Can it be done without? Absolutely. But I'll leave that as an exercise for you.







share|improve this answer














share|improve this answer



share|improve this answer








edited Apr 22 at 3:56









mdfst13

17.9k62357




17.9k62357










answered Apr 21 at 12:58









MastMast

7,74363788




7,74363788












  • $begingroup$
    How would you split it up?
    $endgroup$
    – thadeuszlay
    Apr 21 at 16:23










  • $begingroup$
    You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
    $endgroup$
    – Sulthan
    Apr 21 at 19:01










  • $begingroup$
    @Sulthan Yes, but that's a philosophical discussion, not a review.
    $endgroup$
    – Mast
    Apr 21 at 20:26






  • 1




    $begingroup$
    You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
    $endgroup$
    – Deduplicator
    Apr 21 at 22:13










  • $begingroup$
    @Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
    $endgroup$
    – Roland Illig
    Apr 22 at 6:36


















  • $begingroup$
    How would you split it up?
    $endgroup$
    – thadeuszlay
    Apr 21 at 16:23










  • $begingroup$
    You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
    $endgroup$
    – Sulthan
    Apr 21 at 19:01










  • $begingroup$
    @Sulthan Yes, but that's a philosophical discussion, not a review.
    $endgroup$
    – Mast
    Apr 21 at 20:26






  • 1




    $begingroup$
    You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
    $endgroup$
    – Deduplicator
    Apr 21 at 22:13










  • $begingroup$
    @Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
    $endgroup$
    – Roland Illig
    Apr 22 at 6:36
















$begingroup$
How would you split it up?
$endgroup$
– thadeuszlay
Apr 21 at 16:23




$begingroup$
How would you split it up?
$endgroup$
– thadeuszlay
Apr 21 at 16:23












$begingroup$
You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
$endgroup$
– Sulthan
Apr 21 at 19:01




$begingroup$
You are converting the number to a string anyway, even if you don't store the string anywhere. A number is an abstract concept. To represent it, you need a string, either binary or a decadic (or any other base). When you start working with decimal representation, you are using a string representation. You cannot define palindrome without a string.
$endgroup$
– Sulthan
Apr 21 at 19:01












$begingroup$
@Sulthan Yes, but that's a philosophical discussion, not a review.
$endgroup$
– Mast
Apr 21 at 20:26




$begingroup$
@Sulthan Yes, but that's a philosophical discussion, not a review.
$endgroup$
– Mast
Apr 21 at 20:26




1




1




$begingroup$
You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
$endgroup$
– Deduplicator
Apr 21 at 22:13




$begingroup$
You could modify the last approach to stop when reverse >= number, and then evaluate. Voila, no danger of overflow.
$endgroup$
– Deduplicator
Apr 21 at 22:13












$begingroup$
@Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
$endgroup$
– Roland Illig
Apr 22 at 6:36




$begingroup$
@Deduplicator when using your approach to test 121 and 1221, the code needs two separate tests. One for odd number of digits, one for even. Or did I miss something?
$endgroup$
– Roland Illig
Apr 22 at 6:36











2












$begingroup$

Are you sure you should generate all those objects and arrays?

And the second code additionally looks quite complex.



Testing whether a number is palindromic is actually quite simple:



function isPalindrome(num) {
var rev = 0
while (rev < num) {
rev = rev * 10 + num % 10
num /= 10
}
return rev == num || rev / 10 == num
}





share|improve this answer









$endgroup$













  • $begingroup$
    This is JavaScript, therefore it's better to compare using === instead of ==.
    $endgroup$
    – Roland Illig
    Apr 22 at 16:36
















2












$begingroup$

Are you sure you should generate all those objects and arrays?

And the second code additionally looks quite complex.



Testing whether a number is palindromic is actually quite simple:



function isPalindrome(num) {
var rev = 0
while (rev < num) {
rev = rev * 10 + num % 10
num /= 10
}
return rev == num || rev / 10 == num
}





share|improve this answer









$endgroup$













  • $begingroup$
    This is JavaScript, therefore it's better to compare using === instead of ==.
    $endgroup$
    – Roland Illig
    Apr 22 at 16:36














2












2








2





$begingroup$

Are you sure you should generate all those objects and arrays?

And the second code additionally looks quite complex.



Testing whether a number is palindromic is actually quite simple:



function isPalindrome(num) {
var rev = 0
while (rev < num) {
rev = rev * 10 + num % 10
num /= 10
}
return rev == num || rev / 10 == num
}





share|improve this answer









$endgroup$



Are you sure you should generate all those objects and arrays?

And the second code additionally looks quite complex.



Testing whether a number is palindromic is actually quite simple:



function isPalindrome(num) {
var rev = 0
while (rev < num) {
rev = rev * 10 + num % 10
num /= 10
}
return rev == num || rev / 10 == num
}






share|improve this answer












share|improve this answer



share|improve this answer










answered Apr 22 at 14:52









DeduplicatorDeduplicator

12.4k2052




12.4k2052












  • $begingroup$
    This is JavaScript, therefore it's better to compare using === instead of ==.
    $endgroup$
    – Roland Illig
    Apr 22 at 16:36


















  • $begingroup$
    This is JavaScript, therefore it's better to compare using === instead of ==.
    $endgroup$
    – Roland Illig
    Apr 22 at 16:36
















$begingroup$
This is JavaScript, therefore it's better to compare using === instead of ==.
$endgroup$
– Roland Illig
Apr 22 at 16:36




$begingroup$
This is JavaScript, therefore it's better to compare using === instead of ==.
$endgroup$
– Roland Illig
Apr 22 at 16:36


















draft saved

draft discarded




















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217827%2fdetermine-whether-an-integer-is-a-palindrome%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Færeyskur hestur Heimild | Tengill | Tilvísanir | LeiðsagnarvalRossið - síða um færeyska hrossið á færeyskuGott ár hjá færeyska hestinum

He _____ here since 1970 . Answer needed [closed]What does “since he was so high” mean?Meaning of “catch birds for”?How do I ensure “since” takes the meaning I want?“Who cares here” meaningWhat does “right round toward” mean?the time tense (had now been detected)What does the phrase “ring around the roses” mean here?Correct usage of “visited upon”Meaning of “foiled rail sabotage bid”It was the third time I had gone to Rome or It is the third time I had been to Rome

Slayer Innehåll Historia | Stil, komposition och lyrik | Bandets betydelse och framgångar | Sidoprojekt och samarbeten | Kontroverser | Medlemmar | Utmärkelser och nomineringar | Turnéer och festivaler | Diskografi | Referenser | Externa länkar | Navigeringsmenywww.slayer.net”Metal Massacre vol. 1””Metal Massacre vol. 3””Metal Massacre Volume III””Show No Mercy””Haunting the Chapel””Live Undead””Hell Awaits””Reign in Blood””Reign in Blood””Gold & Platinum – Reign in Blood””Golden Gods Awards Winners”originalet”Kerrang! Hall Of Fame””Slayer Looks Back On 37-Year Career In New Video Series: Part Two””South of Heaven””Gold & Platinum – South of Heaven””Seasons in the Abyss””Gold & Platinum - Seasons in the Abyss””Divine Intervention””Divine Intervention - Release group by Slayer””Gold & Platinum - Divine Intervention””Live Intrusion””Undisputed Attitude””Abolish Government/Superficial Love””Release “Slatanic Slaughter: A Tribute to Slayer” by Various Artists””Diabolus in Musica””Soundtrack to the Apocalypse””God Hates Us All””Systematic - Relationships””War at the Warfield””Gold & Platinum - War at the Warfield””Soundtrack to the Apocalypse””Gold & Platinum - Still Reigning””Metallica, Slayer, Iron Mauden Among Winners At Metal Hammer Awards””Eternal Pyre””Eternal Pyre - Slayer release group””Eternal Pyre””Metal Storm Awards 2006””Kerrang! Hall Of Fame””Slayer Wins 'Best Metal' Grammy Award””Slayer Guitarist Jeff Hanneman Dies””Bullet-For My Valentine booed at Metal Hammer Golden Gods Awards””Unholy Aliance””The End Of Slayer?””Slayer: We Could Thrash Out Two More Albums If We're Fast Enough...””'The Unholy Alliance: Chapter III' UK Dates Added”originalet”Megadeth And Slayer To Co-Headline 'Canadian Carnage' Trek”originalet”World Painted Blood””Release “World Painted Blood” by Slayer””Metallica Heading To Cinemas””Slayer, Megadeth To Join Forces For 'European Carnage' Tour - Dec. 18, 2010”originalet”Slayer's Hanneman Contracts Acute Infection; Band To Bring In Guest Guitarist””Cannibal Corpse's Pat O'Brien Will Step In As Slayer's Guest Guitarist”originalet”Slayer’s Jeff Hanneman Dead at 49””Dave Lombardo Says He Made Only $67,000 In 2011 While Touring With Slayer””Slayer: We Do Not Agree With Dave Lombardo's Substance Or Timeline Of Events””Slayer Welcomes Drummer Paul Bostaph Back To The Fold””Slayer Hope to Unveil Never-Before-Heard Jeff Hanneman Material on Next Album””Slayer Debut New Song 'Implode' During Surprise Golden Gods Appearance””Release group Repentless by Slayer””Repentless - Slayer - Credits””Slayer””Metal Storm Awards 2015””Slayer - to release comic book "Repentless #1"””Slayer To Release 'Repentless' 6.66" Vinyl Box Set””BREAKING NEWS: Slayer Announce Farewell Tour””Slayer Recruit Lamb of God, Anthrax, Behemoth + Testament for Final Tour””Slayer lägger ner efter 37 år””Slayer Announces Second North American Leg Of 'Final' Tour””Final World Tour””Slayer Announces Final European Tour With Lamb of God, Anthrax And Obituary””Slayer To Tour Europe With Lamb of God, Anthrax And Obituary””Slayer To Play 'Last French Show Ever' At Next Year's Hellfst””Slayer's Final World Tour Will Extend Into 2019””Death Angel's Rob Cavestany On Slayer's 'Farewell' Tour: 'Some Of Us Could See This Coming'””Testament Has No Plans To Retire Anytime Soon, Says Chuck Billy””Anthrax's Scott Ian On Slayer's 'Farewell' Tour Plans: 'I Was Surprised And I Wasn't Surprised'””Slayer””Slayer's Morbid Schlock””Review/Rock; For Slayer, the Mania Is the Message””Slayer - Biography””Slayer - Reign In Blood”originalet”Dave Lombardo””An exclusive oral history of Slayer”originalet”Exclusive! Interview With Slayer Guitarist Jeff Hanneman”originalet”Thinking Out Loud: Slayer's Kerry King on hair metal, Satan and being polite””Slayer Lyrics””Slayer - Biography””Most influential artists for extreme metal music””Slayer - Reign in Blood””Slayer guitarist Jeff Hanneman dies aged 49””Slatanic Slaughter: A Tribute to Slayer””Gateway to Hell: A Tribute to Slayer””Covered In Blood””Slayer: The Origins of Thrash in San Francisco, CA.””Why They Rule - #6 Slayer”originalet”Guitar World's 100 Greatest Heavy Metal Guitarists Of All Time”originalet”The fans have spoken: Slayer comes out on top in readers' polls”originalet”Tribute to Jeff Hanneman (1964-2013)””Lamb Of God Frontman: We Sound Like A Slayer Rip-Off””BEHEMOTH Frontman Pays Tribute To SLAYER's JEFF HANNEMAN””Slayer, Hatebreed Doing Double Duty On This Year's Ozzfest””System of a Down””Lacuna Coil’s Andrea Ferro Talks Influences, Skateboarding, Band Origins + More””Slayer - Reign in Blood””Into The Lungs of Hell””Slayer rules - en utställning om fans””Slayer and Their Fans Slashed Through a No-Holds-Barred Night at Gas Monkey””Home””Slayer””Gold & Platinum - The Big 4 Live from Sofia, Bulgaria””Exclusive! Interview With Slayer Guitarist Kerry King””2008-02-23: Wiltern, Los Angeles, CA, USA””Slayer's Kerry King To Perform With Megadeth Tonight! - Oct. 21, 2010”originalet”Dave Lombardo - Biography”Slayer Case DismissedArkiveradUltimate Classic Rock: Slayer guitarist Jeff Hanneman dead at 49.”Slayer: "We could never do any thing like Some Kind Of Monster..."””Cannibal Corpse'S Pat O'Brien Will Step In As Slayer'S Guest Guitarist | The Official Slayer Site”originalet”Slayer Wins 'Best Metal' Grammy Award””Slayer Guitarist Jeff Hanneman Dies””Kerrang! Awards 2006 Blog: Kerrang! Hall Of Fame””Kerrang! Awards 2013: Kerrang! Legend”originalet”Metallica, Slayer, Iron Maien Among Winners At Metal Hammer Awards””Metal Hammer Golden Gods Awards””Bullet For My Valentine Booed At Metal Hammer Golden Gods Awards””Metal Storm Awards 2006””Metal Storm Awards 2015””Slayer's Concert History””Slayer - Relationships””Slayer - Releases”Slayers officiella webbplatsSlayer på MusicBrainzOfficiell webbplatsSlayerSlayerr1373445760000 0001 1540 47353068615-5086262726cb13906545x(data)6033143kn20030215029