Hackerrank All Women's Codesprint 2019: Name the ProductMaximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors

risk of flooding in petra in november

Why is the "ls" command showing permissions of files in a FAT32 partition?

What are some good ways to treat frozen vegetables such that they behave like fresh vegetables when stir frying them?

Shouldn’t conservatives embrace universal basic income?

Refactor a hash table solution to twoSum

"It doesn't matter" or "it won't matter"?

Has the laser at Magurele, Romania reached a tenth of the Sun's power?

X marks the what?

Why do ¬, ∀ and ∃ have the same precedence?

Open a doc from terminal, but not by its name

Delete multiple columns using awk or sed

What to do when eye contact makes your coworker uncomfortable?

Does an advisor owe his/her student anything? Will an advisor keep a PhD student only out of pity?

This is why we puzzle

What is the duration of the spell Creation when used to create non-precious metals?

Why does Java 12 try to convert the result of a switch to a number?

Does the Linux kernel need a file system to run?

Strong empirical falsification of quantum mechanics based on vacuum energy density?

How to get directions in deep space?

Has any country ever had 2 former presidents in jail simultaneously?

Do we have to expect a queue for the shuttle from Watford Junction to Harry Potter Studio?

Why is so much work done on numerical verification of the Riemann Hypothesis?

How to align my equation to left?

Why does the Sun have different day lengths, but not the gas giants?



Hackerrank All Women's Codesprint 2019: Name the Product


Maximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors













4












$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:38






  • 11




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    Mar 18 at 10:41






  • 3




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    Mar 18 at 10:43










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:46






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    Mar 18 at 12:52















4












$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:38






  • 11




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    Mar 18 at 10:41






  • 3




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    Mar 18 at 10:43










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:46






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    Mar 18 at 12:52













4












4








4


1



$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$




Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.







python performance beginner programming-challenge






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Mar 18 at 10:37









Tobi AlafinTobi Alafin

643110




643110











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:38






  • 11




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    Mar 18 at 10:41






  • 3




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    Mar 18 at 10:43










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:46






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    Mar 18 at 12:52
















  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:38






  • 11




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    Mar 18 at 10:41






  • 3




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    Mar 18 at 10:43










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    Mar 18 at 10:46






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    Mar 18 at 12:52















$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
Mar 18 at 10:38




$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
Mar 18 at 10:38




11




11




$begingroup$
Absolutely not.
$endgroup$
– Mast
Mar 18 at 10:41




$begingroup$
Absolutely not.
$endgroup$
– Mast
Mar 18 at 10:41




3




3




$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
Mar 18 at 10:43




$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
Mar 18 at 10:43












$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
Mar 18 at 10:46




$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
Mar 18 at 10:46




3




3




$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
Mar 18 at 12:52




$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
Mar 18 at 12:52










1 Answer
1






active

oldest

votes


















15












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    Mar 18 at 18:28










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    Mar 18 at 18:59






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    Mar 18 at 19:03






  • 6




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    Mar 18 at 20:25







  • 3




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    Mar 18 at 20:36











Your Answer





StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









15












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    Mar 18 at 18:28










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    Mar 18 at 18:59






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    Mar 18 at 19:03






  • 6




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    Mar 18 at 20:25







  • 3




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    Mar 18 at 20:36
















15












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    Mar 18 at 18:28










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    Mar 18 at 18:59






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    Mar 18 at 19:03






  • 6




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    Mar 18 at 20:25







  • 3




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    Mar 18 at 20:36














15












15








15





$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$



Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!







share|improve this answer














share|improve this answer



share|improve this answer








edited Mar 18 at 11:55









Toby Speight

26.5k742118




26.5k742118










answered Mar 18 at 11:15









LudisposedLudisposed

8,93822267




8,93822267







  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    Mar 18 at 18:28










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    Mar 18 at 18:59






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    Mar 18 at 19:03






  • 6




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    Mar 18 at 20:25







  • 3




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    Mar 18 at 20:36













  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    Mar 18 at 18:28










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    Mar 18 at 18:59






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    Mar 18 at 19:03






  • 6




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    Mar 18 at 20:25







  • 3




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    Mar 18 at 20:36








6




6




$begingroup$
May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
$endgroup$
– jpmc26
Mar 18 at 18:28




$begingroup$
May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
$endgroup$
– jpmc26
Mar 18 at 18:28












$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
Mar 18 at 18:59




$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
Mar 18 at 18:59




5




5




$begingroup$
Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
Mar 18 at 19:03




$begingroup$
Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
Mar 18 at 19:03




6




6




$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
Mar 18 at 20:25





$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
Mar 18 at 20:25





3




3




$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
Mar 18 at 20:36





$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
Mar 18 at 20:36


















draft saved

draft discarded
















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Færeyskur hestur Heimild | Tengill | Tilvísanir | LeiðsagnarvalRossið - síða um færeyska hrossið á færeyskuGott ár hjá færeyska hestinum

He _____ here since 1970 . Answer needed [closed]What does “since he was so high” mean?Meaning of “catch birds for”?How do I ensure “since” takes the meaning I want?“Who cares here” meaningWhat does “right round toward” mean?the time tense (had now been detected)What does the phrase “ring around the roses” mean here?Correct usage of “visited upon”Meaning of “foiled rail sabotage bid”It was the third time I had gone to Rome or It is the third time I had been to Rome

Slayer Innehåll Historia | Stil, komposition och lyrik | Bandets betydelse och framgångar | Sidoprojekt och samarbeten | Kontroverser | Medlemmar | Utmärkelser och nomineringar | Turnéer och festivaler | Diskografi | Referenser | Externa länkar | Navigeringsmenywww.slayer.net”Metal Massacre vol. 1””Metal Massacre vol. 3””Metal Massacre Volume III””Show No Mercy””Haunting the Chapel””Live Undead””Hell Awaits””Reign in Blood””Reign in Blood””Gold & Platinum – Reign in Blood””Golden Gods Awards Winners”originalet”Kerrang! Hall Of Fame””Slayer Looks Back On 37-Year Career In New Video Series: Part Two””South of Heaven””Gold & Platinum – South of Heaven””Seasons in the Abyss””Gold & Platinum - Seasons in the Abyss””Divine Intervention””Divine Intervention - Release group by Slayer””Gold & Platinum - Divine Intervention””Live Intrusion””Undisputed Attitude””Abolish Government/Superficial Love””Release “Slatanic Slaughter: A Tribute to Slayer” by Various Artists””Diabolus in Musica””Soundtrack to the Apocalypse””God Hates Us All””Systematic - Relationships””War at the Warfield””Gold & Platinum - War at the Warfield””Soundtrack to the Apocalypse””Gold & Platinum - Still Reigning””Metallica, Slayer, Iron Mauden Among Winners At Metal Hammer Awards””Eternal Pyre””Eternal Pyre - Slayer release group””Eternal Pyre””Metal Storm Awards 2006””Kerrang! Hall Of Fame””Slayer Wins 'Best Metal' Grammy Award””Slayer Guitarist Jeff Hanneman Dies””Bullet-For My Valentine booed at Metal Hammer Golden Gods Awards””Unholy Aliance””The End Of Slayer?””Slayer: We Could Thrash Out Two More Albums If We're Fast Enough...””'The Unholy Alliance: Chapter III' UK Dates Added”originalet”Megadeth And Slayer To Co-Headline 'Canadian Carnage' Trek”originalet”World Painted Blood””Release “World Painted Blood” by Slayer””Metallica Heading To Cinemas””Slayer, Megadeth To Join Forces For 'European Carnage' Tour - Dec. 18, 2010”originalet”Slayer's Hanneman Contracts Acute Infection; Band To Bring In Guest Guitarist””Cannibal Corpse's Pat O'Brien Will Step In As Slayer's Guest Guitarist”originalet”Slayer’s Jeff Hanneman Dead at 49””Dave Lombardo Says He Made Only $67,000 In 2011 While Touring With Slayer””Slayer: We Do Not Agree With Dave Lombardo's Substance Or Timeline Of Events””Slayer Welcomes Drummer Paul Bostaph Back To The Fold””Slayer Hope to Unveil Never-Before-Heard Jeff Hanneman Material on Next Album””Slayer Debut New Song 'Implode' During Surprise Golden Gods Appearance””Release group Repentless by Slayer””Repentless - Slayer - Credits””Slayer””Metal Storm Awards 2015””Slayer - to release comic book "Repentless #1"””Slayer To Release 'Repentless' 6.66" Vinyl Box Set””BREAKING NEWS: Slayer Announce Farewell Tour””Slayer Recruit Lamb of God, Anthrax, Behemoth + Testament for Final Tour””Slayer lägger ner efter 37 år””Slayer Announces Second North American Leg Of 'Final' Tour””Final World Tour””Slayer Announces Final European Tour With Lamb of God, Anthrax And Obituary””Slayer To Tour Europe With Lamb of God, Anthrax And Obituary””Slayer To Play 'Last French Show Ever' At Next Year's Hellfst””Slayer's Final World Tour Will Extend Into 2019””Death Angel's Rob Cavestany On Slayer's 'Farewell' Tour: 'Some Of Us Could See This Coming'””Testament Has No Plans To Retire Anytime Soon, Says Chuck Billy””Anthrax's Scott Ian On Slayer's 'Farewell' Tour Plans: 'I Was Surprised And I Wasn't Surprised'””Slayer””Slayer's Morbid Schlock””Review/Rock; For Slayer, the Mania Is the Message””Slayer - Biography””Slayer - Reign In Blood”originalet”Dave Lombardo””An exclusive oral history of Slayer”originalet”Exclusive! Interview With Slayer Guitarist Jeff Hanneman”originalet”Thinking Out Loud: Slayer's Kerry King on hair metal, Satan and being polite””Slayer Lyrics””Slayer - Biography””Most influential artists for extreme metal music””Slayer - Reign in Blood””Slayer guitarist Jeff Hanneman dies aged 49””Slatanic Slaughter: A Tribute to Slayer””Gateway to Hell: A Tribute to Slayer””Covered In Blood””Slayer: The Origins of Thrash in San Francisco, CA.””Why They Rule - #6 Slayer”originalet”Guitar World's 100 Greatest Heavy Metal Guitarists Of All Time”originalet”The fans have spoken: Slayer comes out on top in readers' polls”originalet”Tribute to Jeff Hanneman (1964-2013)””Lamb Of God Frontman: We Sound Like A Slayer Rip-Off””BEHEMOTH Frontman Pays Tribute To SLAYER's JEFF HANNEMAN””Slayer, Hatebreed Doing Double Duty On This Year's Ozzfest””System of a Down””Lacuna Coil’s Andrea Ferro Talks Influences, Skateboarding, Band Origins + More””Slayer - Reign in Blood””Into The Lungs of Hell””Slayer rules - en utställning om fans””Slayer and Their Fans Slashed Through a No-Holds-Barred Night at Gas Monkey””Home””Slayer””Gold & Platinum - The Big 4 Live from Sofia, Bulgaria””Exclusive! Interview With Slayer Guitarist Kerry King””2008-02-23: Wiltern, Los Angeles, CA, USA””Slayer's Kerry King To Perform With Megadeth Tonight! - Oct. 21, 2010”originalet”Dave Lombardo - Biography”Slayer Case DismissedArkiveradUltimate Classic Rock: Slayer guitarist Jeff Hanneman dead at 49.”Slayer: "We could never do any thing like Some Kind Of Monster..."””Cannibal Corpse'S Pat O'Brien Will Step In As Slayer'S Guest Guitarist | The Official Slayer Site”originalet”Slayer Wins 'Best Metal' Grammy Award””Slayer Guitarist Jeff Hanneman Dies””Kerrang! Awards 2006 Blog: Kerrang! Hall Of Fame””Kerrang! Awards 2013: Kerrang! Legend”originalet”Metallica, Slayer, Iron Maien Among Winners At Metal Hammer Awards””Metal Hammer Golden Gods Awards””Bullet For My Valentine Booed At Metal Hammer Golden Gods Awards””Metal Storm Awards 2006””Metal Storm Awards 2015””Slayer's Concert History””Slayer - Relationships””Slayer - Releases”Slayers officiella webbplatsSlayer på MusicBrainzOfficiell webbplatsSlayerSlayerr1373445760000 0001 1540 47353068615-5086262726cb13906545x(data)6033143kn20030215029