HashMap containsKey() returns false although hashCode() and equals() are true
I have a HashMap<Vertex, Integer> called vertexIndexes. If I iterate through it with this code:
public boolean search(String vertexName){
for (Vertex name: vertexIndexes.keySet()){
String key = name.toString();
String value = vertexIndexes.get(name).toString();
System.out.println(key + " " + value + " "+ (name.hashCode() == vertexName.hashCode()) + " " + name.equals(vertexName));
}
...
}
it produces this output:
Diessen 0 false false
Herrsching 5 false false
Schondorf 2 false false
Greifenberg 3 false false
Stegen 4 false false
Utting 1 false false
Andechs 6 false false
Fischen 7 true true
So you can see, that the Vertex Fischen is present and the hashCode and equals methods work fine. But if I run
vertexIndexes.containsKey("Fischen")
it returns false.
Why is that? I lose my mind over it.
java hashmap
edited 16 hours ago
Eran
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
|
show 1 more comment
I have a HashMap<Vertex, Integer> called vertexIndexes. If I iterate through it with this code:
public boolean search(String vertexName){
for (Vertex name: vertexIndexes.keySet()){
String key = name.toString();
String value = vertexIndexes.get(name).toString();
System.out.println(key + " " + value + " "+ (name.hashCode() == vertexName.hashCode()) + " " + name.equals(vertexName));
}
...
}
it produces this output:
Diessen 0 false false
Herrsching 5 false false
Schondorf 2 false false
Greifenberg 3 false false
Stegen 4 false false
Utting 1 false false
Andechs 6 false false
Fischen 7 true true
So you can see, that the Vertex Fischen is present and the hashCode and equals methods work fine. But if I run
vertexIndexes.containsKey("Fischen")
it returns false.
Why is that? I lose my mind over it.
java hashmap
edited 16 hours ago
Eran
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
11
So the keys are instances ofVertex, not ofString? But the key you are checking for is aString. AStringwill never be equal to anything but anotherString.
– khelwood
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
8
toString()is irrelevant, and even if yourVertexinstance claims to be equal to aString, theStringinstance will not say it is equal to aVertex.
– khelwood
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
1
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago
|
show 1 more comment
I have a HashMap<Vertex, Integer> called vertexIndexes. If I iterate through it with this code:
public boolean search(String vertexName){
for (Vertex name: vertexIndexes.keySet()){
String key = name.toString();
String value = vertexIndexes.get(name).toString();
System.out.println(key + " " + value + " "+ (name.hashCode() == vertexName.hashCode()) + " " + name.equals(vertexName));
}
...
}
it produces this output:
Diessen 0 false false
Herrsching 5 false false
Schondorf 2 false false
Greifenberg 3 false false
Stegen 4 false false
Utting 1 false false
Andechs 6 false false
Fischen 7 true true
So you can see, that the Vertex Fischen is present and the hashCode and equals methods work fine. But if I run
vertexIndexes.containsKey("Fischen")
it returns false.
Why is that? I lose my mind over it.
java hashmap
edited 16 hours ago
Eran
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
I have a HashMap<Vertex, Integer> called vertexIndexes. If I iterate through it with this code:
public boolean search(String vertexName){
for (Vertex name: vertexIndexes.keySet()){
String key = name.toString();
String value = vertexIndexes.get(name).toString();
System.out.println(key + " " + value + " "+ (name.hashCode() == vertexName.hashCode()) + " " + name.equals(vertexName));
}
...
}
it produces this output:
Diessen 0 false false
Herrsching 5 false false
Schondorf 2 false false
Greifenberg 3 false false
Stegen 4 false false
Utting 1 false false
Andechs 6 false false
Fischen 7 true true
So you can see, that the Vertex Fischen is present and the hashCode and equals methods work fine. But if I run
vertexIndexes.containsKey("Fischen")
it returns false.
Why is that? I lose my mind over it.
java hashmap
java hashmap
edited 16 hours ago
Eran
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
edited 16 hours ago
Eran
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
edited 16 hours ago
Eran
290k37477563
edited 16 hours ago
Eran
290k37477563
edited 16 hours ago
Eran
290k37477563
290k37477563
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
asked 17 hours ago
gutenmorgenuhugutenmorgenuhu
1,66811229
1,66811229
11
So the keys are instances ofVertex, not ofString? But the key you are checking for is aString. AStringwill never be equal to anything but anotherString.
– khelwood
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
8
toString()is irrelevant, and even if yourVertexinstance claims to be equal to aString, theStringinstance will not say it is equal to aVertex.
– khelwood
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
1
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago
|
show 1 more comment
11
So the keys are instances ofVertex, not ofString? But the key you are checking for is aString. AStringwill never be equal to anything but anotherString.
– khelwood
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
8
toString()is irrelevant, and even if yourVertexinstance claims to be equal to aString, theStringinstance will not say it is equal to aVertex.
– khelwood
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
1
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago
11
11
So the keys are instances of
Vertex, not of String? But the key you are checking for is a String. A String will never be equal to anything but another String.– khelwood
17 hours ago
So the keys are instances of
Vertex, not of String? But the key you are checking for is a String. A String will never be equal to anything but another String.– khelwood
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
8
8
toString() is irrelevant, and even if your Vertex instance claims to be equal to a String, the String instance will not say it is equal to a Vertex.– khelwood
17 hours ago
toString() is irrelevant, and even if your Vertex instance claims to be equal to a String, the String instance will not say it is equal to a Vertex.– khelwood
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
1
1
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago
|
show 1 more comment
1 Answer
1
active
oldest
votes
name.equals(vertexName) compares a Vertex to a String. While your Vertex class equals method might return true when you pass a String to it, String's equals will never return true when you pass a Vertex to it.
HashMap probably tests whether vertexName.equals(name), which returns false.
Change
vertexIndexes.containsKey("Fischen")
to
vertexIndexes.containsKey(new Vertex("Fischen"))
or change the key of your Map to String.
BTW, you could have avoided that issue in the first place if you followed the contract of the equals method that appears in the Javadoc of the Object class:
• It is symmetric: for any non-null reference values x and y, x.equals(y) should return true if and only if y.equals(x) returns true.
Your equals implementation is not symmetric.
answered 17 hours ago
EranEran
290k37477563
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55354319%2fhashmap-containskey-returns-false-although-hashcode-and-equals-are-true%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
name.equals(vertexName) compares a Vertex to a String. While your Vertex class equals method might return true when you pass a String to it, String's equals will never return true when you pass a Vertex to it.
HashMap probably tests whether vertexName.equals(name), which returns false.
Change
vertexIndexes.containsKey("Fischen")
to
vertexIndexes.containsKey(new Vertex("Fischen"))
or change the key of your Map to String.
BTW, you could have avoided that issue in the first place if you followed the contract of the equals method that appears in the Javadoc of the Object class:
• It is symmetric: for any non-null reference values x and y, x.equals(y) should return true if and only if y.equals(x) returns true.
Your equals implementation is not symmetric.
answered 17 hours ago
EranEran
290k37477563
add a comment |
name.equals(vertexName) compares a Vertex to a String. While your Vertex class equals method might return true when you pass a String to it, String's equals will never return true when you pass a Vertex to it.
HashMap probably tests whether vertexName.equals(name), which returns false.
Change
vertexIndexes.containsKey("Fischen")
to
vertexIndexes.containsKey(new Vertex("Fischen"))
or change the key of your Map to String.
BTW, you could have avoided that issue in the first place if you followed the contract of the equals method that appears in the Javadoc of the Object class:
• It is symmetric: for any non-null reference values x and y, x.equals(y) should return true if and only if y.equals(x) returns true.
Your equals implementation is not symmetric.
answered 17 hours ago
EranEran
290k37477563
add a comment |
name.equals(vertexName) compares a Vertex to a String. While your Vertex class equals method might return true when you pass a String to it, String's equals will never return true when you pass a Vertex to it.
HashMap probably tests whether vertexName.equals(name), which returns false.
Change
vertexIndexes.containsKey("Fischen")
to
vertexIndexes.containsKey(new Vertex("Fischen"))
or change the key of your Map to String.
BTW, you could have avoided that issue in the first place if you followed the contract of the equals method that appears in the Javadoc of the Object class:
• It is symmetric: for any non-null reference values x and y, x.equals(y) should return true if and only if y.equals(x) returns true.
Your equals implementation is not symmetric.
answered 17 hours ago
EranEran
290k37477563
name.equals(vertexName) compares a Vertex to a String. While your Vertex class equals method might return true when you pass a String to it, String's equals will never return true when you pass a Vertex to it.
HashMap probably tests whether vertexName.equals(name), which returns false.
Change
vertexIndexes.containsKey("Fischen")
to
vertexIndexes.containsKey(new Vertex("Fischen"))
or change the key of your Map to String.
BTW, you could have avoided that issue in the first place if you followed the contract of the equals method that appears in the Javadoc of the Object class:
• It is symmetric: for any non-null reference values x and y, x.equals(y) should return true if and only if y.equals(x) returns true.
Your equals implementation is not symmetric.
answered 17 hours ago
EranEran
290k37477563
edited 16 hours ago
answered 17 hours ago
EranEran
290k37477563
answered 17 hours ago
EranEran
290k37477563
answered 17 hours ago
EranEran
290k37477563
290k37477563
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55354319%2fhashmap-containskey-returns-false-although-hashcode-and-equals-are-true%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
11
So the keys are instances of
Vertex, not ofString? But the key you are checking for is aString. AStringwill never be equal to anything but anotherString.– khelwood
17 hours ago
As you can see in my output (..true true..): I implemented the toString() and equals method of Vertex to correctly compare it to a String.
– gutenmorgenuhu
17 hours ago
8
toString()is irrelevant, and even if yourVertexinstance claims to be equal to aString, theStringinstance will not say it is equal to aVertex.– khelwood
17 hours ago
@khelwood unless in a very alternative implementation of an equals method :)
– Stultuske
17 hours ago
1
Possible duplicate of What issues should be considered when overriding equals and hashCode in Java?
– Lino
17 hours ago