expected `}' at end of input
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600){
analogWrite (9, b);
}
}
arduino-uno programming
New contributor
|
show 1 more comment
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600){
analogWrite (9, b);
}
}
arduino-uno programming
New contributor
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing}
should be.
– sempaiscuba
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
1
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking
– jsotola
12 hours ago
|
show 1 more comment
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600){
analogWrite (9, b);
}
}
arduino-uno programming
New contributor
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600){
analogWrite (9, b);
}
}
arduino-uno programming
arduino-uno programming
New contributor
New contributor
edited 12 hours ago
Michel Keijzers
6,97251939
6,97251939
New contributor
asked 13 hours ago
Đức HòangĐức Hòang
41
41
New contributor
New contributor
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing}
should be.
– sempaiscuba
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
1
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking
– jsotola
12 hours ago
|
show 1 more comment
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing}
should be.
– sempaiscuba
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
1
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking
– jsotola
12 hours ago
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing
}
should be.– sempaiscuba
13 hours ago
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing
}
should be.– sempaiscuba
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
1
1
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking– jsotola
12 hours ago
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking– jsotola
12 hours ago
|
show 1 more comment
2 Answers
2
active
oldest
votes
Some guidelines for programming:
Start each statement on a new line
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
} void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: "); Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: "); Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = "); {
for(int a = 255; a>=0;a--) {
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a); }
for(int a = 0; a<256; a++) {
analogWrite(6, a); {
if(pressure_bar < 1600){
analogWrite (6, a); }
for(int b = 255; b>=0;b--) {
analogWrite(9, b); {
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b); }
for(int b = 0; b<256; b++) {
analogWrite(9, b); {
if (pressure_bar > 1600){
analogWrite (9, b);
} }
Use brackets and align them
.. so each pair of { and } is on the same column and align code with brackets to be indented 2, 3 or 4 spaces
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600)
{
analogWrite (9, b);
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
Remove superfluous brackets
As you can see, you are having some superfluous/missing brackets. What you want is probably something like:
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
}
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar == 1600)
{
analogWrite (9, b);
}
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
}
Remove duplicate code
In the if statement, you perform twice the same code (both you send an analogWrite
with the same value, so the code (from the for loops can be reduced to:
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar >= 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar <= 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar <= 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar >= 1600)
{
analogWrite (9, b);
}
}
}
Unclear
What is unclear why you first write an analog value, and directly afterward (in each if) you write the same value. I'm not sure what you really want here. Either you want to write to a different pin, or you want a delay (to have the value having some effect), I'm just not sure.
add a comment |
Look at your open brackets { vs closing brackets, }. You need the same number of each. If have this in the Arduino IDE and use CTRL-T, they are somewhat easy to find. I just looked, and I can spot them pretty easily.
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{ << bracket for what?
for(int a = 255; a>=0;a--) { << missing closing bracket
analogWrite(6,a);
if (pressure_bar = 1600){ << missing closing bracket
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++) {
analogWrite(6, a);
{ << wrong direction
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar == 1600){ << missing closing bracket
analogWrite (9, b);
if(pressure_bar < 1600){ << missing closing bracket
analogWrite (9, b);
}
for(int b = 0; b<256; b++) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar > 1600){
analogWrite (9, b);
}
} << closing bracket for loop
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("schematics", function () {
StackExchange.schematics.init();
});
}, "cicuitlab");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "540"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Đức Hòang is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2farduino.stackexchange.com%2fquestions%2f63354%2fexpected-at-end-of-input%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
Some guidelines for programming:
Start each statement on a new line
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
} void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: "); Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: "); Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = "); {
for(int a = 255; a>=0;a--) {
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a); }
for(int a = 0; a<256; a++) {
analogWrite(6, a); {
if(pressure_bar < 1600){
analogWrite (6, a); }
for(int b = 255; b>=0;b--) {
analogWrite(9, b); {
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b); }
for(int b = 0; b<256; b++) {
analogWrite(9, b); {
if (pressure_bar > 1600){
analogWrite (9, b);
} }
Use brackets and align them
.. so each pair of { and } is on the same column and align code with brackets to be indented 2, 3 or 4 spaces
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600)
{
analogWrite (9, b);
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
Remove superfluous brackets
As you can see, you are having some superfluous/missing brackets. What you want is probably something like:
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
}
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar == 1600)
{
analogWrite (9, b);
}
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
}
Remove duplicate code
In the if statement, you perform twice the same code (both you send an analogWrite
with the same value, so the code (from the for loops can be reduced to:
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar >= 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar <= 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar <= 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar >= 1600)
{
analogWrite (9, b);
}
}
}
Unclear
What is unclear why you first write an analog value, and directly afterward (in each if) you write the same value. I'm not sure what you really want here. Either you want to write to a different pin, or you want a delay (to have the value having some effect), I'm just not sure.
add a comment |
Some guidelines for programming:
Start each statement on a new line
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
} void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: "); Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: "); Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = "); {
for(int a = 255; a>=0;a--) {
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a); }
for(int a = 0; a<256; a++) {
analogWrite(6, a); {
if(pressure_bar < 1600){
analogWrite (6, a); }
for(int b = 255; b>=0;b--) {
analogWrite(9, b); {
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b); }
for(int b = 0; b<256; b++) {
analogWrite(9, b); {
if (pressure_bar > 1600){
analogWrite (9, b);
} }
Use brackets and align them
.. so each pair of { and } is on the same column and align code with brackets to be indented 2, 3 or 4 spaces
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600)
{
analogWrite (9, b);
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
Remove superfluous brackets
As you can see, you are having some superfluous/missing brackets. What you want is probably something like:
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
}
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar == 1600)
{
analogWrite (9, b);
}
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
}
Remove duplicate code
In the if statement, you perform twice the same code (both you send an analogWrite
with the same value, so the code (from the for loops can be reduced to:
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar >= 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar <= 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar <= 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar >= 1600)
{
analogWrite (9, b);
}
}
}
Unclear
What is unclear why you first write an analog value, and directly afterward (in each if) you write the same value. I'm not sure what you really want here. Either you want to write to a different pin, or you want a delay (to have the value having some effect), I'm just not sure.
add a comment |
Some guidelines for programming:
Start each statement on a new line
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
} void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: "); Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: "); Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = "); {
for(int a = 255; a>=0;a--) {
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a); }
for(int a = 0; a<256; a++) {
analogWrite(6, a); {
if(pressure_bar < 1600){
analogWrite (6, a); }
for(int b = 255; b>=0;b--) {
analogWrite(9, b); {
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b); }
for(int b = 0; b<256; b++) {
analogWrite(9, b); {
if (pressure_bar > 1600){
analogWrite (9, b);
} }
Use brackets and align them
.. so each pair of { and } is on the same column and align code with brackets to be indented 2, 3 or 4 spaces
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600)
{
analogWrite (9, b);
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
Remove superfluous brackets
As you can see, you are having some superfluous/missing brackets. What you want is probably something like:
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
}
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar == 1600)
{
analogWrite (9, b);
}
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
}
Remove duplicate code
In the if statement, you perform twice the same code (both you send an analogWrite
with the same value, so the code (from the for loops can be reduced to:
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar >= 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar <= 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar <= 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar >= 1600)
{
analogWrite (9, b);
}
}
}
Unclear
What is unclear why you first write an analog value, and directly afterward (in each if) you write the same value. I'm not sure what you really want here. Either you want to write to a different pin, or you want a delay (to have the value having some effect), I'm just not sure.
Some guidelines for programming:
Start each statement on a new line
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup() {
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
} void loop(){
sensorVal = analogRead(A1);
Serial.print("Sensor Value: "); Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: "); Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = "); {
for(int a = 255; a>=0;a--) {
analogWrite(6,a);
if (pressure_bar = 1600){
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a); }
for(int a = 0; a<256; a++) {
analogWrite(6, a); {
if(pressure_bar < 1600){
analogWrite (6, a); }
for(int b = 255; b>=0;b--) {
analogWrite(9, b); {
if (pressure_bar == 1600){
analogWrite (9, b);
if(pressure_bar < 1600){
analogWrite (9, b); }
for(int b = 0; b<256; b++) {
analogWrite(9, b); {
if (pressure_bar > 1600){
analogWrite (9, b);
} }
Use brackets and align them
.. so each pair of { and } is on the same column and align code with brackets to be indented 2, 3 or 4 spaces
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
{
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
{
if (pressure_bar == 1600)
{
analogWrite (9, b);
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
{
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
Remove superfluous brackets
As you can see, you are having some superfluous/missing brackets. What you want is probably something like:
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0; Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar = 1600)
{
analogWrite (6, a);
}
if (pressure_bar > 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar < 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar == 1600)
{
analogWrite (9, b);
}
if(pressure_bar < 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar > 1600)
{
analogWrite (9, b);
}
}
}
Remove duplicate code
In the if statement, you perform twice the same code (both you send an analogWrite
with the same value, so the code (from the for loops can be reduced to:
for(int a = 255; a>=0;a--)
{
analogWrite(6,a);
if (pressure_bar >= 1600)
{
analogWrite (6, a);
}
}
for(int a = 0; a<256; a++)
{
analogWrite(6, a);
if(pressure_bar <= 1600)
{
analogWrite (6, a);
}
}
for(int b = 255; b>=0;b--)
{
analogWrite(9, b);
if (pressure_bar <= 1600)
{
analogWrite (9, b);
}
}
for(int b = 0; b<256; b++)
{
analogWrite(9, b);
if (pressure_bar >= 1600)
{
analogWrite (9, b);
}
}
}
Unclear
What is unclear why you first write an analog value, and directly afterward (in each if) you write the same value. I'm not sure what you really want here. Either you want to write to a different pin, or you want a delay (to have the value having some effect), I'm just not sure.
edited 12 hours ago
answered 13 hours ago
Michel KeijzersMichel Keijzers
6,97251939
6,97251939
add a comment |
add a comment |
Look at your open brackets { vs closing brackets, }. You need the same number of each. If have this in the Arduino IDE and use CTRL-T, they are somewhat easy to find. I just looked, and I can spot them pretty easily.
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{ << bracket for what?
for(int a = 255; a>=0;a--) { << missing closing bracket
analogWrite(6,a);
if (pressure_bar = 1600){ << missing closing bracket
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++) {
analogWrite(6, a);
{ << wrong direction
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar == 1600){ << missing closing bracket
analogWrite (9, b);
if(pressure_bar < 1600){ << missing closing bracket
analogWrite (9, b);
}
for(int b = 0; b<256; b++) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar > 1600){
analogWrite (9, b);
}
} << closing bracket for loop
add a comment |
Look at your open brackets { vs closing brackets, }. You need the same number of each. If have this in the Arduino IDE and use CTRL-T, they are somewhat easy to find. I just looked, and I can spot them pretty easily.
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{ << bracket for what?
for(int a = 255; a>=0;a--) { << missing closing bracket
analogWrite(6,a);
if (pressure_bar = 1600){ << missing closing bracket
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++) {
analogWrite(6, a);
{ << wrong direction
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar == 1600){ << missing closing bracket
analogWrite (9, b);
if(pressure_bar < 1600){ << missing closing bracket
analogWrite (9, b);
}
for(int b = 0; b<256; b++) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar > 1600){
analogWrite (9, b);
}
} << closing bracket for loop
add a comment |
Look at your open brackets { vs closing brackets, }. You need the same number of each. If have this in the Arduino IDE and use CTRL-T, they are somewhat easy to find. I just looked, and I can spot them pretty easily.
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{ << bracket for what?
for(int a = 255; a>=0;a--) { << missing closing bracket
analogWrite(6,a);
if (pressure_bar = 1600){ << missing closing bracket
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++) {
analogWrite(6, a);
{ << wrong direction
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar == 1600){ << missing closing bracket
analogWrite (9, b);
if(pressure_bar < 1600){ << missing closing bracket
analogWrite (9, b);
}
for(int b = 0; b<256; b++) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar > 1600){
analogWrite (9, b);
}
} << closing bracket for loop
Look at your open brackets { vs closing brackets, }. You need the same number of each. If have this in the Arduino IDE and use CTRL-T, they are somewhat easy to find. I just looked, and I can spot them pretty easily.
int scvVal = 6;
int drvVal = 9;
int sensorVal = A1;
void setup()
{
Serial.begin(9600);
pinMode(6, OUTPUT);
pinMode(9, OUTPUT);
}
void loop()
{
sensorVal = analogRead(A1);
Serial.print("Sensor Value: ");
Serial.print(sensorVal);
float voltage = (sensorVal*5.0)/1024.0;
Serial.print("Volts: ");
Serial.print(voltage);
float pressure_pascal = (400.0*((float)voltage-0.5))*1000000.0;
float pressure_bar = pressure_pascal/10e5;
Serial.print("Pressure = ");
Serial.print(pressure_bar);
Serial.println(" bars");
Serial.print("Pressure = ");
{ << bracket for what?
for(int a = 255; a>=0;a--) { << missing closing bracket
analogWrite(6,a);
if (pressure_bar = 1600){ << missing closing bracket
analogWrite (6, a);
if (pressure_bar > 1600){
analogWrite (6, a);
}
for(int a = 0; a<256; a++) {
analogWrite(6, a);
{ << wrong direction
if(pressure_bar < 1600){
analogWrite (6, a);
}
for(int b = 255; b>=0;b--) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar == 1600){ << missing closing bracket
analogWrite (9, b);
if(pressure_bar < 1600){ << missing closing bracket
analogWrite (9, b);
}
for(int b = 0; b<256; b++) {
analogWrite(9, b);
{ << wrong direction
if (pressure_bar > 1600){
analogWrite (9, b);
}
} << closing bracket for loop
answered 13 hours ago
CrossRoadsCrossRoads
1,58117
1,58117
add a comment |
add a comment |
Đức Hòang is a new contributor. Be nice, and check out our Code of Conduct.
Đức Hòang is a new contributor. Be nice, and check out our Code of Conduct.
Đức Hòang is a new contributor. Be nice, and check out our Code of Conduct.
Đức Hòang is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Arduino Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2farduino.stackexchange.com%2fquestions%2f63354%2fexpected-at-end-of-input%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Welcome to Arduino:SE. Your life would be so much easier if you indented your code correctly. It would then be fairly obvious where the missing
}
should be.– sempaiscuba
13 hours ago
do you help me?
– Đức Hòang
13 hours ago
@Duc Hoang: Are you formatting your code correctly, that it is readable? Select in in the question editor and click on the {} button
– chrisl
13 hours ago
Never before have I see such random use of brackets... ;)
– Majenko♦
12 hours ago
1
do you help me?
.... you have to start by helping yourself ..... read and understand the answers below ..... do not copy and paste code without thinking– jsotola
12 hours ago